refactor: root chunk_id should be equal to app_hash
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
changed the title
chunk_id should be equal to app_hash
fominok
reviewed
Jun 3, 2024
| @@ -346,15 +340,14 @@ impl GroveDb { | |||
| // state_sync_info: Consumed StateSyncInfo | |||
| // app_hash: Snapshot's AppHash | |||
| // tx: Transaction for the state sync | |||
| // Returns the first set of global chunk ids that can be fetched from sources (+ | |||
| // the StateSyncInfo transferring ownership back to the caller) | |||
| // Returns the StateSyncInfo transferring ownership back to the caller) | |||
| pub fn start_snapshot_syncing<'db>( | |||
| &'db self, | |||
| mut state_sync_info: MultiStateSyncInfo<'db>, | |||
There was a problem hiding this comment.
perhaps could be a &mut without that ownership return trick
There was a problem hiding this comment.
this PR doesn't contain changes of #300
fominok
approved these changes
Jun 3, 2024
QuantumExplorer
requested changes
Jun 3, 2024
Comment on lines
+123
to
+128
| if global_chunk_id == app_hash { | ||
| let array_of_zeros: [u8; 32] = [0; 32]; | ||
| let root_chunk_prefix_key: crate::SubtreePrefix = array_of_zeros; | ||
| return Ok((root_chunk_prefix_key, vec![])); | ||
| } | ||
|
|
There was a problem hiding this comment.
In rust you shouldn't have special numbers, meaning that [0;32] shouldn't have a special signicance, instead you should use enums or Options
QuantumExplorer
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
app_hashinstead ofnull_hash(This facilitates Tenderdash in state sync init phase)appy_chunkto accept separately parameters and not in tuple (better clarity)How Has This Been Tested?
Updated tutorial
replicationBreaking Changes
Checklist:
For repository code-owners and collaborators only