Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to bincode 2, clean up dependencies #288

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Apr 5, 2024

Issue being fixed or feature implemented

A few dependencies were not useful, they have been removed, we also switched to bincode 2 and use big endian encoding.

What was done?

How Has This Been Tested?

Benchmarks were ran, things are roughly the same speed.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit f5a3382 into develop Apr 5, 2024
7 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/ElementVerifyDebug branch April 5, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants