Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different behavior addCdmName and addCohortName #680

Closed
catalamarti opened this issue Jul 24, 2024 · 2 comments · Fixed by #684
Closed

different behavior addCdmName and addCohortName #680

catalamarti opened this issue Jul 24, 2024 · 2 comments · Fixed by #684
Assignees
Labels
enhancement New feature or request

Comments

@catalamarti
Copy link
Collaborator

If the column already exists:

  • addCdmName overwrites it
  • addCohortName two resultant columns are created: cohort_name.x and cohort_name.y

what behavior do we want?

@xihang-chen
Copy link
Collaborator

I think overwrite for addCohortName() makes more sense. Although I think it could be nice to throw an warning that it has been overwritten.

A user that uses these functions probably don't know these columns already exist in their data frame so I think overwrite is fine. Plus I don't think cohort_name.x and cohort_name.y are informative column names.

@catalamarti
Copy link
Collaborator Author

catalamarti commented Jul 25, 2024

agreed
-> change addCohortName to overwrite column if this already exist (throw warning/message)

@catalamarti catalamarti added enhancement New feature or request and removed needs dicussion labels Jul 25, 2024
@nmercadeb nmercadeb linked a pull request Jul 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants