Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring source_maps #11

Open
DartBot opened this issue Jun 5, 2015 · 2 comments
Open

refactoring source_maps #11

DartBot opened this issue Jun 5, 2015 · 2 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://github.com/avatars/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#19930


source_maps was a kitchen sink before we had other uses for what we have there. It should probably be refactored as follows:

 - span - should be its own pacakge
 - source_maps parser & builder should stay
 - refactor & printer - should go to code_transformers?

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://github.com/avatars/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


+Nathan, since he is already looking into factoring Span into its own package.


cc @nex3.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://github.com/avatars/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Set owner to @nex3.
Added Started label.

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Priority-Medium labels Jun 5, 2015
@nex3 nex3 removed their assignment Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants