Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Push Members Down & Safe Delete Refactor #55930

Open
Tracked by #55825
bvoq opened this issue Jun 4, 2024 · 0 comments
Open
Tracked by #55825

Feature Request: Push Members Down & Safe Delete Refactor #55930

bvoq opened this issue Jun 4, 2024 · 0 comments
Labels
analyzer-refactoring area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@bvoq
Copy link

bvoq commented Jun 4, 2024

The JetBrains team has added some crucial methods for improving code refactors with introducing ReSharper into Kotlin, but also into the C# and Java world.

Whenever you enter a codebase that has the following code smells, push members down/safe delete is very useful:
Speculative generality: https://refactoring.guru/smells/speculative-generality
Deep Hierarchy: Having classes that extend other classes that extend other classes ...

With push members down, you can remove methods and fields from a class and push them to their subclasses respectively. Safe delete does the same thing but in addition deletes the intermediate class.

image image

Maybe add the refactor here: Requests for Dart refactorings

@bwilkerson bwilkerson added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-refactoring labels Jun 4, 2024
@keertip keertip added P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-refactoring area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants