Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] onnx-simplifier fails YOLOv5 CI checks on Windows #141

Closed
glenn-jocher opened this issue Apr 16, 2021 · 1 comment
Closed

[BUG] onnx-simplifier fails YOLOv5 CI checks on Windows #141

glenn-jocher opened this issue Apr 16, 2021 · 1 comment

Comments

@glenn-jocher
Copy link

Describe the bug
onnx-simplifier package fails pip install onnx-simplifier command on GitHub actions on windows-latest environment.
https://github.com/ultralytics/yolov5/pull/2815/checks?check_run_id=2361765551

Screenshot 2021-04-16 at 13 42 09
@glenn-jocher glenn-jocher mentioned this issue Apr 16, 2021
Merged
@glenn-jocher
Copy link
Author

glenn-jocher commented Apr 16, 2021 •
edited
Loading

Bug was on our side in YOLOv5 check_requirements() function. Colons on the pip install 'onnx-simplifier' command were failing on windows, so ultralytics/yolov5@6005670 removed the colons for pip install onnx-simplifier and this succeeds on all 3 operating systems.

Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glenn-jocher