Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable raw metadata for Pub/Sub with .WithTopic<> Extension. #860

Closed
DarrenClevenger opened this issue Apr 11, 2022 · 3 comments
Closed
Assignees
Labels
good first issue Good for newcomers kind/bug Something isn't working
Milestone

Comments

@DarrenClevenger
Copy link

When using .Net 6 Minimal APIs I expected to be able to specify I want to enable raw payloads.

X.WithTopic(name, topic, enableRawPayload).

However, I see no way to pass a "enable raw payload" value to the extension.

I would expect to have this option just as with using the attribute.

TopicAttribute(string pubsubName, string name, bool enableRawPayload);

@DarrenClevenger DarrenClevenger added the kind/bug Something isn't working label Apr 11, 2022
@halspang
Copy link
Contributor

Looks like this was just missed when we added RawPayload. It'd be a pretty straight-forward fix adding the new method to this class:

https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.AspNetCore/DaprEndpointConventionBuilderExtensions.cs

@halspang halspang added the good first issue Good for newcomers label Apr 14, 2022
@stulzq
Copy link
Contributor

stulzq commented Apr 18, 2022

/assign

@halspang halspang added this to the v1.8 milestone May 26, 2022
@halspang
Copy link
Contributor

This was completed in #864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants