Fix error being set into txt file #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3alpha
reviewed
Dec 20, 2023
bind/entrypoint.sh
Outdated
| domain=$fetched_domain | ||
| else | ||
| echo "Failed to fetch DOMAIN" | ||
| kill $pid |
There was a problem hiding this comment.
Why this? DNS server should continue running in any case.
There was a problem hiding this comment.
Okay, you are right
pablomendezroyo
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempts failed when trying to fetch both the domain or the internal IP, these errors ended up being written into the file
cloacking-rules.txt