Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include link text in json result file #49

Closed
gitressa opened this issue Feb 20, 2019 · 4 comments
Closed

Include link text in json result file #49

gitressa opened this issue Feb 20, 2019 · 4 comments

Comments

@gitressa
Copy link
Contributor

gitressa commented Feb 20, 2019

Would it be possible to also include the link text of tested links in the json result file (--output=out.json)?

It would speed up finding the links, if you update via an editor like CKEditor, and not directly in the HTML source code.

@gitressa
Copy link
Contributor Author

gitressa commented Mar 6, 2019

I am still interested in this feature, and even got a use case for it now :-)
Would it be hard to add?

@dantleech
Copy link
Owner

dantleech commented Mar 6, 2019

What's your use case? This feature would help finding the dead link, but any more use cases around it would help (and it's not hard to add, but then it might add additional complexity going forward, so that it might nead a bit of consideration).

Maybe rather than showing the link text, it should provide the text of the whole HTML element containing the link.

@gitressa
Copy link
Contributor Author

gitressa commented Mar 6, 2019

It's basically like I wrote, that if you edit large pages via an editor like CKEditor, and not directly in the HTML source code, it would speed up the process of finding the links, if you are able to search for the link text.

@dantleech
Copy link
Owner

Fixed in #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants