Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php min requirement #112

Open
clxmstaab opened this issue Nov 13, 2020 · 4 comments
Open

php min requirement #112

clxmstaab opened this issue Nov 13, 2020 · 4 comments

Comments

@clxmstaab
Copy link

clxmstaab commented Nov 13, 2020

fink's composer.json states a php-min requirement of 7.2

"php": "^7.2",

its still not possible to install it on php 7.2 because it depends on a lib which requires at least 7.3:

$ composer require dantleech/fink --dev
Using version ^0.10.1 for dantleech/fink
./composer.json has been updated
Gathering patches for root package.
Loading composer repositories with package information
install without a lock file, no new packages will be mirrored.
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - phpactor/container 1.3.3 requires php ^7.3 -> your PHP version (7.4.5) overridden by "config.platform.php" version (7.2.30) does not satisfy that requirement.
    - phpactor/container 1.3.3 requires php ^7.3 -> your PHP version (7.4.5) overridden by "config.platform.php" version (7.2.30) does not satisfy that requirement.
    - phpactor/container 1.3.3 requires php ^7.3 -> your PHP version (7.4.5) overridden by "config.platform.php" version (7.2.30) does not satisfy that requirement.
    - Installation request for phpactor/container (locked at 1.3.3) -> satisfiable by phpactor/container[1.3.3].
$ composer why phpactor/container
dantleech/fink              0.10.1  requires  phpactor/container (^1.0)
phpactor/console-extension  0.1.5   requires  phpactor/container (^1.0)

is this intentional?

@dantleech
Copy link
Owner

dantleech commented Nov 13, 2020

it should work -- 1.3.3 requires 7.3, but 1.2.xhas no such restriction. Try deleting your lock file?

@clxmstaab
Copy link
Author

just deleted the composer.lock but it runs into the same error

@clxmstaab
Copy link
Author

clxmstaab commented Nov 13, 2020

I can reproduce with the following composer.json

{
    "config" : {
        "optimize-autoloader" : true,
        "platform" : {
            "php": "7.2.20"
        }
    },
    "require-dev": {
    }
}

and

$ composer require dantleech/fink --dev
Using version ^0.10.1 for dantleech/fink
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - phpactor/container 1.3.3 requires php ^7.3 -> your PHP version (7.4.5) overridden by "config.platform.php" version (7.2.20) does not satisfy that requirement.
    - phpactor/container 1.3.3 requires php ^7.3 -> your PHP version (7.4.5) overridden by "config.platform.php" version (7.2.20) does not satisfy that requirement.
    - Installation request for phpactor/container (installed at 1.3.3) -> satisfiable by phpactor/container[1.3.3].


Installation failed, reverting ./composer.json to its original content.

using

$ composer diagnose
Checking composer.json: WARNING
No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.
Checking platform settings: OK
Checking git settings: OK
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
Checking github.com oauth access: OK
Checking disk free space: OK
Checking pubkeys:
Tags Public Key Fingerprint: 57815BA2 7E54DC31 7ECC7CC5 573090D0  87719BA6 8F3BB723 4E5D42D0 84A14642
Dev Public Key Fingerprint: 4AC45767 E5EC2265 2F0C1167 CBBB8A2B  0C708369 153E328C AD90147D AFE50952
OK
Checking composer version: You are not running the latest stable version, run `composer self-update` to update (1.10.17 => 2.0.6)
Composer version: 1.10.17
PHP version: 7.2.20 - Package overridden via config.platform (actual: 7.4.5)
PHP binary path: C:\tools\php74\php.exe
OpenSSL version: OpenSSL 1.1.1e  17 Mar 2020

@dantleech
Copy link
Owner

dantleech commented Nov 13, 2020

Very odd, your example works for me with both composer 1 and 2:

$ composer require dantleech/fink --dev                                                                                                ✘ 130 
Warning from https://repo.packagist.org: You are using an outdated version of Composer. Composer 2.0 is now available and you should upgrade. See https://getcomposer.org/2
Using version ^0.10.1 for dantleech/fink
./composer.json has been updated
Loading composer repositories with package information
Warning from https://repo.packagist.org: You are using an outdated version of Composer. Composer 2.0 is now available and you should upgrade. See https://getcomposer.org/2
Updating dependencies (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
  - Installing symfony/polyfill-ctype (v1.20.0): Downloading (100%)         
  - Installing webmozart/assert (1.9.1): Loading from cache
  - Installing webmozart/path-util (2.3.0): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing phpactor/map-resolver (1.2.2): Downloading (100%)         
  - Installing phpactor/container (1.3.2): Downloading (100%)  

Composer 1 diagnose:

Checking composer.json: WARNING
No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.
Checking platform settings: OK
Checking git settings: OK
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
Checking github.com oauth access: OK
Checking disk free space: OK
Checking pubkeys: 
Tags Public Key Fingerprint: 57815BA2 7E54DC31 7ECC7CC5 573090D0  87719BA6 8F3BB723 4E5D42D0 84A14642
Dev Public Key Fingerprint: 4AC45767 E5EC2265 2F0C1167 CBBB8A2B  0C708369 153E328C AD90147D AFE50952
OK
Checking composer version: You are not running the latest stable version, run `composer self-update` to update (1.10.8 => 2.0.6)
Composer version: 1.10.8
PHP version: 7.2.20 - Package overridden via config.platform (actual: 7.4.3)
PHP binary path: /usr/bin/php7.4
OpenSSL version: OpenSSL 1.1.1d  10 Sep 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants