Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query response leak in iTerm2? #2531

Closed
michaelsbradleyjr opened this issue Jan 5, 2022 · 12 comments
Closed

query response leak in iTerm2? #2531

michaelsbradleyjr opened this issue Jan 5, 2022 · 12 comments
Assignees
Labels
bug Something isn't working macOS
Milestone

Comments

@michaelsbradleyjr
Copy link
Collaborator

michaelsbradleyjr commented Jan 5, 2022

See the screenshot below. You'll want to open it in a separate window and zoom to 200% so the terminal output is legible.

That sequence of inputs is received by notcurses_get_blocking as soon as the program starts, i.e. I haven't pressed any keys. It happens every time.

The program is my same cli1 referenced in #2524, with some updates following that discussion.

However, what I'm seeing I've been seeing in my cli1 in iTerm2 since I started work on it; but I spend a lot more time in Kitty these days, so I just now thought to check in iTerm2 again and report the issue.

I am not versed in the details of Notcurses queries but I've read or skimmed enough issues and PRs in this repo that I have a sense that a leaked response is what I'm looking at.

Or, maybe this is fully expected given the way in which cli1 makes use of notcurses_get_blocking?
image

@michaelsbradleyjr michaelsbradleyjr added the bug Something isn't working label Jan 5, 2022
@dankamongmen dankamongmen self-assigned this Jan 6, 2022
@dankamongmen
Copy link
Owner

nahj this is definitely query stuff bleeding through. i imagine the same thing happens running notcurses-input?

@dankamongmen
Copy link
Owner

any love on getting my cobra account back up btw? =]

@dankamongmen
Copy link
Owner

so this isn't bleedthrough, actually, but rather an XTSMGRAPHICS error message.

i'm seeing here \e[?1;3;S. that's not quite what's specified, but we can handle it. one moment please.

@michaelsbradleyjr
Copy link
Collaborator Author

nahj this is definitely query stuff bleeding through. i imagine the same thing happens running notcurses-input?

Indeed.
image

@dankamongmen
Copy link
Owner

if you could, please update from master and see what matter of thing we might have here. you want commit 5de0a24.

@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 6, 2022
@dankamongmen
Copy link
Owner

i think that'll get it, based on what i'm seeing here. probably ought file a bug against iTerm2 for its out-of-spec response.

@michaelsbradleyjr
Copy link
Collaborator Author

any love on getting my cobra account back up btw? =]

Whoops, forgot to do that.

However, the way the remote desktop works, as far as when I tested it, it's not per user, and I'm logged into cobra-la's desktop locally pretty much 24/7 (I needed to start working with a large monitor that my laptop wasn't driving effectively). So your account would be limited to ssh access, and I'm not sure how much use that will be. Were you at any point able to try latest iTerm2 stable/beta on that older mac laptop you have, and did it work? I think iTerm2 only supports macOS 10.14+.

@dankamongmen
Copy link
Owner

However, the way the remote desktop works, as far as when I tested it, it's not per user, and I'm logged into cobra-la's desktop locally pretty much 24/7 (I needed to start working with a large monitor that my laptop wasn't driving effectively). So your account would be limited to ssh access, and I'm not sure how much use that will be. Were you at any point able to try latest iTerm2 stable/beta on that older mac laptop you have, and did it work? I think iTerm2 only supports macOS 10.14+.

i'm gonna sound pretty bougie here but i gave it away to my maid lol

@michaelsbradleyjr
Copy link
Collaborator Author

I needed to start working with a large monitor that my laptop wasn't driving effectively

Sorry for the inconvenience, btw.

I think iTerm2 only supports macOS 10.14+

And... yes, that's the case, which means that my older mac laptop isn't an option either, as it's stuck permanently on 10.13. 😦

@dankamongmen
Copy link
Owner

all good. did that commit get it?

@michaelsbradleyjr
Copy link
Collaborator Author

Seems to have fixed it, nice work!

image

image

@dankamongmen
Copy link
Owner

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS
Projects
None yet
Development

No branches or pull requests

2 participants