Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIDS validator tests create bids-validator-report_*.log files in repository root #948

Closed
jwodder opened this issue Apr 6, 2022 · 2 comments · Fixed by #954
Closed

BIDS validator tests create bids-validator-report_*.log files in repository root #948

jwodder opened this issue Apr 6, 2022 · 2 comments · Fixed by #954
Assignees
@TheChymera
Labels
BIDS released severity-important tests Add or improve existing tests

Comments

@jwodder
Copy link
Member

jwodder commented Apr 6, 2022

Any transient files created as part of tests should be created in a temporary directory, ideally one provisioned using pytest's tmp_path fixture.
@jwodder jwodder added tests Add or improve existing tests BIDS labels Apr 6, 2022
@yarikoptic
Copy link
Member

FWIW: just ran into this as well ! Now I wonder if we didn't ship some logs within conda etc packages ;) raising severity

@TheChymera TheChymera mentioned this issue Apr 7, 2022
Merged
@github-actions
Copy link

🚀 Issue was released in 0.39.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheChymera TheChymera

Labels
BIDS released severity-important tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed test_write_report() log path issue dandi/dandi-cli
3 participants
@yarikoptic @jwodder @TheChymera