Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Dandisets on staging not validating in under two minutes #1365

Closed
jwodder opened this issue Nov 11, 2022 · 7 comments
Closed

Simple Dandisets on staging not validating in under two minutes #1365

jwodder opened this issue Nov 11, 2022 · 7 comments

Comments

@jwodder
Copy link
Member

jwodder commented Nov 11, 2022

Once again, the backups2datalad tests are failing because the test Dandisets created by the tests are not validating for publication in time.

@waxlamp
Copy link
Member

waxlamp commented Nov 11, 2022

@jwodder, can you point us to a specific failing test so we can try to see what's going on?

@jwodder
Copy link
Member Author

jwodder commented Nov 11, 2022

@yarikoptic
Copy link
Member

citing for posterity

FAILED test_backups2datalad/test_core.py::test_1 - ValueError: Dandiset 205806 is Invalid: {
    "asset_validation_errors": [
        {
            "field": "new.txt",
            "message": "asset is currently being validated, please wait."
        }
    ],
    "version_validation_errors": []
}
FAILED test_backups2datalad/test_core.py::test_2 - ValueError: Dandiset 205810 is Invalid: {
    "asset_validation_errors": [
        {
            "field": "counter.txt",
            "message": "asset is currently being validated, please wait."
        }
    ],
    "version_validation_errors": []
}
FAILED test_backups2datalad/test_core.py::test_3 - ValueError: Dandiset 205812 is Invalid: {
    "asset_validation_errors": [
        {
            "field": "counter.txt",
            "message": "asset is currently being validated, please wait."
        }
    ],
    "version_validation_errors": []
}
FAILED test_backups2datalad/test_core.py::test_4 - ValueError: Dandiset 205814 is Invalid: {
    "asset_validation_errors": [
        {
            "field": "counter.txt",
            "message": "asset is currently being validated, please wait."
        }
    ],
    "version_validation_errors": []
}
=================== 4 failed, 11 passed in 684.93s (0:11:24) ===================

@yarikoptic
Copy link
Member

I still wonder how we have "missed" that while testing against dandi-cli... @jwodder -- don't we have some tests in dandi-cli which would cause similar workflow? if so -- then I guess the problem lies in the difference of "real deployment" from simple docker-compose one.

@jwodder
Copy link
Member Author

jwodder commented Nov 17, 2022

@yarikoptic Yes, there are dandi-cli tests that publish Dandisets, so presumably the problem lies with the staging instance.

@yarikoptic
Copy link
Member

is this still the case @jwodder?

@jwodder
Copy link
Member Author

jwodder commented Feb 7, 2023

@yarikoptic No, this seems to have been resolved between December 5 and December 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants