convert postgres encoding to python ones #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
force-pushed
the
encoding
branch
5 times, most recently
from
60e87aa
to
179f09f
Compare
blogh
reviewed
Mar 15, 2023
blogh
reviewed
Mar 15, 2023
blogh
approved these changes
Mar 15, 2023
PostgreSQL and Python have different names for encodings. Since we retrieve PostgreSQL encoding name from 'pg_catalog.pg_encoding_to_char(pg_database.encoding)' and then use this to decode Python bytes, we need to convert the former into a Python encoding name. We thus use psycopg._encodings.pg2pyenc() to translate encoding names; this is not part of the public API of psycopg at the moment, but should be in the future. For psycopg2, we implement a fallback mechanism in pg.decode(); not all PostgreSQL encodings will then be accounted for. Typically, from https://www.postgresql.org/docs/current/multibyte.html#CHARSET-TABLE, KOI8R, KOI8U and WIN* are not handled (as far as I can tell). (SQL_ASCII is not handled either, but the fallback is enough.) Test previously introduced using SQL_ASCII now passes. Additionally, we add another test in which there is no mapping between Python and PostgreSQL: zh_TW. In CI, we thus add zh_TW to the host locales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses second part of #348.