Replace backend_type with is_background_worker #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit attempts to solve the issue : dalibo#130 [1]. * PoWA has a bug where `backend_type` is not correctly filled [2]. it was fixed but it's not in the stable version yet. * Since [3], we queried for the `backend_type` and filtered `parallel workers` in the Python code. The test is now done in SQL, which avoids the problems all together. * The `parallel worker` detection was not working for pg 11+ because it uses the 'parallel worker' backend_type. It's now fixed. [1] dalibo#130 [2] powa-team/powa-archivist#20 [3] dalibo@6a180d8
julmon
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend_typeis not correctly filled [2]. itwas fixed but it's not in the stable version yet.
backend_typeand filteredparallel workersin the Python code. The test is now done inSQL, which avoids the problems all together.
parallel workerdetection was not working for pg 11+ becauseit uses the 'parallel worker' backend_type. It's now fixed.
[1] #130
[2] powa-team/powa-archivist#20
[3] 6a180d8