Fix issue with infinite replicas when replicas > 1 (9.2 backport) #7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenc-FNAL
changed the title
|
retest this please |
How to do this, please? Close/re-open appears to be ineffective. |
Resolve issue with infinite replicas being created whenever more than one requested. Motivation: If a `migration copy` command specifies `-replicas=n` where `n>1`, then replicas are continuously created across all eligible pools. Modules: dcache Modification: The record of completed replica destinations (a `set`) was actually being populated with the source pool rather than the target pool: this has been corrected. Result: The `migration copy` command with `-replicas=n` (`n>1`) has the desired behavior of creating only `n` replicas. Release notes: Pool migration : fixed behavior of `migration copy` with `-replicas=n` (where `n>1`) to behave as expected. Target: master Request: 9.2, 10.0 Patch: https://rb.dcache.org/r/14275/ Requires-notes: yes Requires-book: no Acked-by: Dmitry Litvinsev Committed:
greenc-FNAL
force-pushed
the
bugfix/multiple-replicas-9.2
branch
from
c50abd9
to
5a9e3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue with infinite replicas being created whenever more than
one requested.
Motivation:
If a
migration copycommand specifies-replicas=nwheren>1, thenreplicas are continuously created across all eligible pools.
Modules:
dcache
Modification:
The record of completed replica destinations (a
set) was actuallybeing populated with the source pool rather than the target pool: this
has been corrected.
Result:
The
migration copycommand with-replicas=n(n>1) has the desiredbehavior of creating only
nreplicas.Release notes:
Pool migration : fixed behavior of
migration copywith-replicas=n(wheren>1) to behave as expected.Target: master
Request: 9.2, 10.0
Patch: https://rb.dcache.org/r/14275/
Requires-notes: yes
Requires-book: no
Acked-by: Dmitry Litvinsev
Committed: