Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for any order of model and formula args #225

Open
falkecarlsen opened this issue Sep 15, 2023 · 1 comment
Open

Allow for any order of model and formula args #225

falkecarlsen opened this issue Sep 15, 2023 · 1 comment
Labels
discussion Details are under discussion enhancement New feature or request good first issue Good for newcomers

Comments

@falkecarlsen
Copy link
Member

Would be nice to allow the following syntax as the improvements from #224 makes model and formula args positional:

./cgaal check model.lcgs query.atl
./cgaal check query.atl model.lcgs

And for #217 also:

./cgaal check model.lcgs query0.atl query1.atl query2.atl

Detection of type would need to be with extension (.atl,lcgs) for JSON, we could attempt to parse the input, to determine its type. This adds a bit of overhead, but minimal, and only for JSON input files.

@falkecarlsen falkecarlsen added enhancement New feature or request good first issue Good for newcomers labels Sep 15, 2023
@NicEastvillage
Copy link
Contributor

I am not sure I want this feature. It adds a tiny quality-of-life feature for users, but a lot of trouble for us, the developers. Trouble that we are going to have to deal with every time we want to change the CLI in the future.

As you mentioned, JSON files (but also extensionless files) must be parsed to determine which is the model and which is the property. If we at some point want to allow another file format (e.g. PRISM), then this problem becomes worse.

For #217 with multiple property files, it only makes sense to have the properties last. I do not want to have to find the model among N paths.

@NicEastvillage NicEastvillage added the discussion Details are under discussion label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Details are under discussion enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants