Correct ja-JP time format #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The old format of date time `"%Y %b %e %a %X"` generates strings like `2020 3月 10 火 15:20:22`, which is not correct. The date part of them should be either `2020/03/10` using slashes as separators or `2020年3月10日` using 年 (year), 月 (month) and 日 (day) as suffixes. Using suffixes partly should be avoided. - Month names are replaced with numeric notation with kanji suffix because these names are obsolete and mostly used for Chinese luni-solar calendar.
Fil
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Looks good. I have verified (to the best of my abilities) with https://github.com/PrestaShop/PrestaShop/blob/develop/localization/CLDR/core/common/main/ja.xml#L2331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"%Y %b %e %a %X"generates strings like2020 3月 10 火 15:20:22, which is not correct. The date part of them should be either2020/03/10using slashes as separators or2020年3月10日using 年 (year), 月 (month) and 日 (day) as suffixes. Using suffixes partly should be avoided.