Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite mixed-type compatibility for _get_table_columns_and_types #82

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Aug 1, 2023

Description

This PR adds changes which seek to further address #38. This extends the work found in #50 for greater compatibility with mixed-types in _get_table_columns_and_types.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment

cytotable/convert.py Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Aug 2, 2023

Thank you @gwaybio for the review! Will merge pending no unexpected tests failing.

@d33bs
Copy link
Member Author

d33bs commented Aug 2, 2023

Note: test failure is related to issues which we seek to address in #83 (missing database file for second SQLite S3 data source parsed from temporary cache location).

@d33bs d33bs merged commit 03f3428 into cytomining:main Aug 2, 2023
5 of 7 checks passed
@d33bs d33bs deleted the mixed-type-column-prep-reads branch August 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants