Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change drop_nulls default in convert() to false #78

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Jul 26, 2023

Description

Changes the convert() default to not drop nulls by default. This is more in-line with expected behavior.

Closes #56

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, LGTM! Marking this as approved with the understanding that the tests will very likely pass after updating from main. The test failure is I believe unrelated to the changes here and instead pertains to issues which are fixed from the merge of #79.

@gwaybio
Copy link
Member Author

gwaybio commented Jul 28, 2023

Thanks @d33bs - tests pass now, I'm going to merge!

@gwaybio gwaybio merged commit 9fafa0d into cytomining:main Jul 28, 2023
4 checks passed
@gwaybio gwaybio deleted the drop-nulls-false-default branch July 28, 2023 20:29
@gwaybio
Copy link
Member Author

gwaybio commented Jul 28, 2023

Tests passed here, but not in the merge: https://github.com/cytomining/CytoTable/actions/runs/5696050273/job/15440405650 🤔

@d33bs
Copy link
Member

d33bs commented Jul 30, 2023

Going to follow up on the errors to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default for drop_nulls=True causes loss of data
2 participants