Add order to limit and offset queries for deterministic results #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #175 by adding
ORDER BY ALL
to SQL queries which are used to help parallelize data work throughLIMIT
andOFFSET
. This comes as the result of various testing surrounding PyArrow, DuckDB, and Parsl and reading + experimentation on what happens during DuckDB queries which leverageLIMIT
,OFFSET
, and lists of Parquet files treated as a single dataset. DuckDB provides documentation supporting this change for determinism:"Note that while LIMIT can be used without an ORDER BY clause, the results might not be deterministic without the ORDER BY clause."
. (link). The same stands for SQLite-based queries (link).These additions required a small changes due to the new sorting order of results.
References #175
May influence work towards #85
Should be prioritized before and will influence further changes in #181
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.