Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DuckDB >= v0.8.0 #114

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Enable DuckDB >= v0.8.0 #114

merged 2 commits into from
Oct 5, 2023

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Sep 27, 2023

Description

This PR enables the use of DuckDB versions >= v0.8.0 (v0.9.0 was just released). I made a minor adjustment to an existing test which appeared to have issues with mixed order of columns.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs
Copy link
Member Author

d33bs commented Oct 5, 2023

Thank you @gwaybio and @falquaddoomi for your reviews! Merging this in.

@d33bs d33bs merged commit a5b5895 into cytomining:main Oct 5, 2023
7 checks passed
@d33bs d33bs deleted the duckdb-dep-bump branch October 5, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants