-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can send FormData with File. #16576
Conversation
Thanks for taking the time to open a PR!
|
Flaky failures I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the 2 tests currently failing are legitimate. Looks like something is causing socket-io's hasBinary
to infinitely recurse.
@chrisbreiding I failed to reproduce the |
I saw the |
User facing changelog
As
socket.io
ignoresFormData
body, Cypress driver couldn't sendFormData
with file. This PR fixes this behavior.Additional details
cy.request()
doesn't support it.socker.io
.How has the user experience changed?
N/A
PR Tasks