Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReactionCounter & ReactionTotal observers #247

Merged
merged 3 commits into from
Apr 9, 2023
Merged

Remove ReactionCounter & ReactionTotal observers #247

merged 3 commits into from
Apr 9, 2023

Conversation

antonkomarev
Copy link
Member

@antonkomarev antonkomarev commented Apr 9, 2023 •
edited
Loading

Keeping default values in Observers makes understanding the code harder and not obvious.

Implementation of the Solution №1:

@antonkomarev antonkomarev changed the title Remove reactant aggregate observers Remove ReactionCounter & ReactionTotal observers Apr 9, 2023
@antonkomarev antonkomarev merged commit 6bf6cd6 into master Apr 9, 2023
@antonkomarev antonkomarev deleted the remove-reactant-aggregate-observers branch April 9, 2023 18:11
@antonkomarev antonkomarev mentioned this pull request Apr 9, 2023
Merged
@antonkomarev antonkomarev changed the title Remove ReactionCounter & ReactionTotal observers Remove ReactionCounter & ReactionTotal observers Apr 9, 2023
@antonkomarev antonkomarev added this to the v10.0 milestone Apr 9, 2023
@antonkomarev antonkomarev mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@antonkomarev