Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #228

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix CI failures #228

merged 1 commit into from
Dec 23, 2021

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Dec 22, 2021

CI is failing due to a new feature with GoReleaser.

GoReleaser 2715 added an
artifacts.json file to the artifacts, but this file has user read permissions only and
is written by root and the other processes cannot read this file.
It is set to 0x600 here

total 11364
-rw------- 1 root root    5887 Dec 23 10:57 artifacts.json
-rw-r--r-- 1 root root    4789 Dec 23 10:57 config.yaml
-rw-r--r-- 1 root root     781 Dec 23 10:57 SHA256SUMS.txt
-rw-r--r-- 1 root root 1442717 Dec 23 10:57 summon_0.9.0-SNAPSHOT-daaf95d_amd64.apk
-rw-r--r-- 1 root root 1442894 Dec 23 10:57 summon_0.9.0-SNAPSHOT-daaf95d_amd64.deb
-rw-r--r-- 1 root root 1441378 Dec 23 10:57 summon_0.9.0-SNAPSHOT-daaf95d_amd64.rpm
drwxr-xr-x 2 root root    4096 Dec 23 10:57 summon-arm_darwin_arm64
drwxr-xr-x 2 root root    4096 Dec 23 10:57 summon_darwin_amd64
-rw-r--r-- 1 root root 1464315 Dec 23 10:57 summon-darwin-amd64.tar.gz
-rw-r--r-- 1 root root 1445187 Dec 23 10:57 summon-darwin-arm64.tar.gz
-rw-r--r-- 1 root root 1439695 Dec 23 10:57 summon-linux-amd64.tar.gz
drwxr-xr-x 2 root root    4096 Dec 23 10:57 summon-linux_linux_amd64
-rw-r--r-- 1 root root    1246 Dec 23 10:57 summon.rb
drwxr-xr-x 2 root root    4096 Dec 23 10:57 summon_solaris_amd64
-rw-r--r-- 1 root root 1417291 Dec 23 10:57 summon-solaris-amd64.tar.gz
drwxr-xr-x 2 root root    4096 Dec 23 10:57 summon_windows_amd64
-rw-r--r-- 1 root root 1480462 Dec 23 10:57 summon-windows-amd64.zip

Desired Outcome

CI should run

Implemented Changes

Ignoring this new artifact.json file

Connected Issue/Story

Resolves #[]

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier force-pushed the test-ci branch 5 times, most recently from b9f9296 to 87f751c Compare December 23, 2021 17:18
@rpothier rpothier changed the title Testing CI Fix CI failures Dec 23, 2021
@rpothier rpothier self-assigned this Dec 23, 2021
@rpothier rpothier marked this pull request as ready for review December 23, 2021 17:39
@rpothier rpothier requested a review from a team as a code owner December 23, 2021 17:39
@rpothier rpothier force-pushed the test-ci branch 3 times, most recently from 21fe27d to 2c3fa6a Compare December 23, 2021 20:03
Goreleaser has added a new file in the dist/goreleaser
directory that is not readable.
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@rpothier rpothier merged commit 0e39b67 into main Dec 23, 2021
@rpothier rpothier deleted the test-ci branch December 23, 2021 21:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants