handle mixed types

cwhanse · Apr 9, 2024 · 32619fb · 32619fb
1 parent 8a73eef
commit 32619fb
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/pvanalytics/features/snow.py b/pvanalytics/features/snow.py
@@ -262,15 +262,11 @@ def categorize(vmp_ratio, transmission, voltage, min_dcv,
        50th Photovoltaic Specialists Conference (PVSC), San Juan, PR, USA,
        2023, pp. 1-5, :doi:`10.1109/PVSC48320.2023.10360065`.
     """
-    mode = np.zeros_like(voltage, dtype=object)  # allows both int and None
-
     umin = voltage > min_dcv  # necessary for all modes except 0
     uvr = np.where(vmp_ratio > threshold_vratio, 3, 1)
     utrans = np.where(transmission > threshold_transmission, 1, 0)
 
-    mode = umin * (uvr + utrans)
-
-    # preserve nan
-    mode[np.isnan(vmp_ratio) | np.isnan(transmission)] = None
+    mode = np.where(np.isnan(vmp_ratio) | np.isnan(transmission), None,
+                    umin * (uvr + utrans))
 
     return mode