Fix Schema constructor so that it picks up config values for the lounge object.

[bojand]

Right now when we do:

var schema = new lounge.Schema(...);

The config settings set in the lounge instance do not get applied to the constructor. We should be able to do this, so that config settings are applied.

[waffledonkey]

Would this set expiry for both the document and the reference? Currently it seems to set expiry you have to do so at the model as part of save() but the references don't get a similar expiry so the document disappears and the references linger. :(

[bojand]

Hello, thanks for your comment. Can you elaborate some more on the use case and maybe provide some sample code. Not sure if it is this issue, but could be a different issue or missed feature.

[waffledonkey]

Sure; and my apologies in advance if this belongs elsewhere. Yours is the only ODM that seems to support expiry; which I need. ☹️

var schema = lounge.schema({
    id: {
        type: String,
        key: true,
        generate: false,
        refKeyCase: 'lower'
    },
    manufacturer: {
        type: String, 
        index: true
    },
    type: String,
    sku: {
        invisible: true,
        type: 'alias',
        target: 'id'
    }
}, {expiry: 60});
// setting expiry here has no effect on either the resulting model instances or their refs

schema.pre('save', function (next) {
    this.type = this.modelName;
    next();
});

var sku = new Sku({
    id: 'sku8260387',
});

// setting expiry here will delete the model after 60 seconds, but the ref will remain indefinitely
sku.save({expiry:60}, function (err, result) {  
    if (err) throw err;
    console.log(result);
});

[bojand]

Ok yes this is a missing feature (and possibly a bug). we can add something like saveOptions to the schema options that can specify expiry, persist_to and replicate_to options, that would be then used globally for all instances of that model / schema. Will try and add this soon.

Can you explain in more detail the schema and the intention of that schema, as it's not clear to me. What do you mean by ref?

[waffledonkey]

the schema was mostly a goof just to compare lounge to competing ODM libraries before I got too far down the path (no offense).

I understand your confusion with "ref"... I didn't think about it at the time, but I stripped the schema down to the bare essentials to demonstrate the expiry issue and in doing so removed the indexed properties that would normally automatically create reference documents. I edited the previous comment to add one back ("manufacturer").

In this scenario, the persisted Sku model instance will expire and be purged from couchbase, but the reference document $_ref_by_manufacturer_<name> will stick around even though the document it references is no longer present.

[bojand]

Hello I have added 2 issues related to this. One is a bug, #65, and one is a feature, #66. Please continue any relevant discussion there. Thanks.