Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plans to support couchbase 3.0 sdk? #187

Open
waffledonkey opened this issue Feb 13, 2020 · 1 comment
Open

plans to support couchbase 3.0 sdk? #187

waffledonkey opened this issue Feb 13, 2020 · 1 comment

Comments

@waffledonkey
Copy link

  1. What version of the module is the issue happening on? Does the issue happen on latest version?
    0.27.0

  2. What platform and Node.js version? (For example Node.js 6.11.2 on Mac OS X)
    10.17 mac OS

  3. Sample source code or steps to reproduce

      const handle = await lounge.connect({
        connectionString: 'couchbase://127.0.0.1?detailed_errcodes=1',
        bucket: REDACTED,
        username: REDACTED,
        password: REDACTED
      })

(Write description of your issue here, stack traces from errors and code that reproduces the issue are helpful)
The above worked under Couchbase Node SDK version 2.4.6 (which meets Lounge's peer dependency) however the same results in "cannot read property username of null" under the 3.0.0 SDK version. If instead I try to connect to Couchbase as per the 3.0 documentation and then pass the bucket to Lounge via the bucket property of the connection options object I get an unhandled promise rejection error which seems odd since everything is using async/await inside of try/catch. My guess is that Couchbase Node SDK 3.0.0 now uses promises whereas the prior version did not and Lounge is assuming that it does not. The new presence of promises is possibly resulting in a double/nested promise situation where one is unresolved? Anyway, none of this is Lounge's fault -- of course -- I'm just curious if there are plans to support the 3.0.0 SDK.

Cheers -- and thank you.

@waffledonkey
Copy link
Author

ping.

I see that ottoman 2 was finally released and is advertised to work with the newer SDK. I may have to switch to that as the 2.4.x couchbase sdk has a number of deprecated dependencies which may -- or may not -- have been fixed in another version of the 2.x branch, but lounge has a peer dependency of 2.4.x specifically

Be safe and stay healthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant