Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin matplotlib version #54

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Pin matplotlib version #54

merged 2 commits into from
Aug 5, 2024

Conversation

Bobronium
Copy link
Member

@Bobronium Bobronium commented Aug 5, 2024

Summary

See #51 (comment) for context

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 CVAT.ai Corporation
#
# SPDX-License-Identifier: MIT

Summary by CodeRabbit

  • Chores
    • Updated package installation strategy for matplotlib to use only binary distributions, streamlining the installation process and reducing potential compatibility issues.

Copy link

coderabbitai bot commented Aug 5, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes to the project involve an enhancement to the package management strategy for matplotlib. By adding the constraint --only-binary matplotlib in the requirements-core.txt, the installation process has been streamlined to exclusively use pre-built binaries. This modification aims to reduce installation time and minimize compatibility issues, facilitating a smoother experience for users and aligning with best practices for dependency management.

Changes

File Change Summary
requirements-core.txt Added --only-binary matplotlib to enforce installation of only binary distributions of matplotlib, improving installation speed and compatibility.

Poem

In fields of code, we leap with glee,
With binaries in tow, how swift we’ll be!
No more to grind, no source to compile,
Just pre-built wonders, let’s code in style!
Hops of joy for changes made,
A smoother path, let’s serenade! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c7bc106 and 11e4850.

Files selected for processing (1)
  • requirements-core.txt (1 hunks)
Additional context used
LanguageTool
requirements-core.txt

[style] ~6-~6: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...=2.10.0 lxml>=4.4.1 matplotlib>=3.3.1 --only-binary matplotlib networkx>=2.5 nibabel>=3.2.1...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

Additional comments not posted (1)
requirements-core.txt (1)

6-6: LGTM! Ensure to update the documentation and tests.

The addition of --only-binary matplotlib is a good practice to avoid potential issues with source builds and reduce installation time.

The static analysis suggestion about the hyphen is not applicable here as --only-binary is a command-line option.

Tools
LanguageTool

[style] ~6-~6: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...=2.10.0 lxml>=4.4.1 matplotlib>=3.3.1 --only-binary matplotlib networkx>=2.5 nibabel>=3.2.1...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

setup.py doesn't play well with that option.
@Bobronium Bobronium changed the title Add --only-binary for matplotlib Pin matplotlib version Aug 5, 2024
Copy link

sonarcloud bot commented Aug 5, 2024

@zhiltsov-max zhiltsov-max merged commit 3cd8bc3 into develop Aug 5, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants