-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin matplotlib version #54
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes to the project involve an enhancement to the package management strategy for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- requirements-core.txt (1 hunks)
Additional context used
LanguageTool
requirements-core.txt
[style] ~6-~6: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...=2.10.0 lxml>=4.4.1 matplotlib>=3.3.1 --only-binary matplotlib networkx>=2.5 nibabel>=3.2.1...(HYPHENATED_LY_ADVERB_ADJECTIVE)
Additional comments not posted (1)
requirements-core.txt (1)
6-6
: LGTM! Ensure to update the documentation and tests.The addition of
--only-binary matplotlib
is a good practice to avoid potential issues with source builds and reduce installation time.The static analysis suggestion about the hyphen is not applicable here as
--only-binary
is a command-line option.Tools
LanguageTool
[style] ~6-~6: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...=2.10.0 lxml>=4.4.1 matplotlib>=3.3.1 --only-binary matplotlib networkx>=2.5 nibabel>=3.2.1...(HYPHENATED_LY_ADVERB_ADJECTIVE)
setup.py doesn't play well with that option.
Quality Gate passedIssues Measures |
Summary
See #51 (comment) for context
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
matplotlib
to use only binary distributions, streamlining the installation process and reducing potential compatibility issues.