Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop after v2.16.2 #8265

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Update develop after v2.16.2 #8265

merged 2 commits into from
Aug 6, 2024

Conversation

cvat-bot[bot]
Copy link
Contributor

@cvat-bot cvat-bot bot commented Aug 6, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced automatic annotation process, especially for cloud-sourced tasks.
    • Added a cancellation button in the delete label modal for improved user control.
  • Bug Fixes

    • Resolved page reload issue when following links in notifications.
    • Fixed copy/paste functionality for annotation guides with assets.
    • Enhanced undo functionality for rotated shapes.
    • Corrected export errors for skeleton tracks and ensured proper handling of export cache.
    • Adjusted request card behavior to prevent confusion after downloads.
    • Resolved ground truth annotation marking errors post-modifications.
    • Fixed API call issues related to automatic annotations on models.
    • Addressed label collision issues during export for similar prefixes.

Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Walkthrough

The version 2.16.2 update significantly enhances user experience and application functionality. Key improvements include streamlined navigation by preventing page reloads from notification links, fixes to the copy/paste and undo functionalities for annotations, and critical enhancements to export processes. Usability improvements, like a cancellation button for deletions and better handling of job retries, further ensure a smoother interaction with the application.

Changes

File(s) Change Summary
CHANGELOG.md Updated to reflect new features and fixes in version 2.16.2.
Notification Links Prevent page reloads when following links in notifications.
Annotation Guides Fixed copy/paste functionality, resolving asset relation errors.
Shape Editing Enhanced undo functionality to support rotated shapes.
Export Functionality Resolved broadcasting error when exporting skeleton tracks; improved export job retries.
Deletion Modal Added cancellation button to the delete label modal for user control.
Automatic Annotations Improved process for tasks from cloud data, enhancing feature applicability.
Request Card Behavior Adjusted behavior to disable request card post-download to prevent confusion.
Ground Truth Annotations Fixed marking issues after modifications to ensure data integrity.
API Calls Resolved issues with automatic annotations when mapping was not provided.
Label Collision Fixed label collision issues with similar prefixes during export.

Poem

In the fields so bright and fair,
Changes sprout like flowers rare. 🌼
No more reloads, just smooth flows,
A button to cancel, as each rabbit knows! 🐇
With fixes and tweaks, our work’s a delight,
Hopping with joy, we code through the night! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (10)
CHANGELOG.md (10)

24-25: Clarify the description for better readability.

The description "Following the link in notification no longer reloads the page" could be more specific about the context or the type of notification.

- Following the link in notification no longer reloads the page
+ Following a link in a notification now navigates without reloading the page

29-30: Clarify the description for better readability.

The description "Copy/paste annotation guide with assets did not work, showing the message Asset is already related to another guide" could be more specific about the context.

- Copy/paste annotation guide with assets did not work, showing the message **Asset is already related to another guide**
+ Fixed an issue where copying/pasting an annotation guide with assets showed the message **Asset is already related to another guide**

32-33: Clarify the description for better readability.

The description "Undo can't be done when a shape is rotated" could be more specific about the context.

- Undo can't be done when a shape is rotated
+ Fixed an issue where undoing actions was not possible when a shape was rotated

35-37: Clarify the description for better readability.

The description "Exporting a skeleton track in a format defined for shapes raises error operands could not be broadcast together with shapes (X, ) (Y, )" could be more specific about the context.

- Exporting a skeleton track in a format defined for shapes raises error `operands could not be broadcast together with shapes (X, ) (Y, )`
+ Fixed an error when exporting a skeleton track in a format defined for shapes, which raised the error `operands could not be broadcast together with shapes (X, ) (Y, )`

39-40: Clarify the description for better readability.

The description "Delete label modal window does not have cancellation button" could be more specific about the context.

- Delete label modal window does not have cancellation button
+ Added a cancellation button to the delete label modal window

42-43: Clarify the description for better readability.

The description "Export and export cache clean rq job retries' hangs" could be more specific about the context.

- Export and export cache clean rq job retries' hangs
+ Fixed an issue where export and export cache clean request job retries would hang

45-46: Clarify the description for better readability.

The description "The automatic annotation process failed for tasks from cloud data" could be more specific about the context.

- The automatic annotation process failed for tasks from cloud data
+ Fixed an issue where the automatic annotation process failed for tasks sourced from cloud data

51-52: Clarify the description for better readability.

The description "Annotations in a ground truth jobs marked as GT annotations after modifying" could be more specific about the context.

- Annotations in a ground truth jobs marked as GT annotations after modifying
+ Fixed an issue where annotations in ground truth jobs were not correctly marked as GT annotations after modifications

54-55: Clarify the description for better readability.

The description "API call to run automatic annotations fails on a model with attributes when mapping not provided in the request" could be more specific about the context.

- API call to run automatic annotations fails on a model with attributes when mapping not provided in the request
+ Fixed an issue where API calls to run automatic annotations failed on models with attributes when mapping was not provided in the request

57-59: Clarify the description for better readability.

The description "Fixed a label collision issue where labels with similar prefixes and numeric suffixes could conflict, causing error on export" could be more specific about the context.

- Fixed a label collision issue where labels with similar prefixes and numeric suffixes could conflict, causing error on export
+ Fixed a label collision issue where labels with similar prefixes and numeric suffixes could conflict, causing errors during export
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a1b6904 and accf33e.

Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

Comment on lines +48 to +49
- Request card was not disabed properly after downloading
(<https://github.com/cvat-ai/cvat/pull/8197>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo.

The description "Request card was not disabed properly after downloading" contains a typo.

- Request card was not disabed properly after downloading
+ Request card was not disabled properly after downloading
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Request card was not disabed properly after downloading
(<https://github.com/cvat-ai/cvat/pull/8197>)
- Request card was not disabed properly after downloading
+ Request card was not disabled properly after downloading

@bsekachev bsekachev merged commit 6e30164 into develop Aug 6, 2024
14 checks passed
@bsekachev bsekachev deleted the dev-release-2.16.2 branch August 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant