Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Cuboids are missed in annotations statistics #2704

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

bsekachev
Copy link
Member

Motivation and context

Resolved #2663

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jan 22, 2021
@bsekachev
Copy link
Member Author

Hi @dvkruchinin

Probably we need to test statistics feature. After quick view of tests I didn't find anything related.
Let's say create several shapes/tracks (including interpolation) of each of rectangle, polygon, polyline, points, cuboid, tag; then open statistics and be sure it shows valid results.

@dvkruchinin
Copy link
Contributor

Hi @dvkruchinin

Probably we need to test statistics feature. After quick view of tests I didn't find anything related.
Let's say create several shapes/tracks (including interpolation) of each of rectangle, polygon, polyline, points, cuboid, tag; then open statistics and be sure it shows valid results.

Hi @bsekachev
This test scenario was proposed based on a code coverage analysis. Of course I will prepare this test.

@coveralls
Copy link

coveralls commented Jan 22, 2021

Coverage Status

Coverage decreased (-0.02%) to 70.303% when pulling a4e0dba on bs/fixed_issue_2663 into 3ced77c on develop.

@bsekachev bsekachev merged commit d48cc53 into develop Jan 27, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_2663 branch January 29, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cuboids are missed in annotations statistics
4 participants