Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from Antd 3.* to Antd 4.9 #2536

Merged
merged 23 commits into from
Dec 9, 2020
Merged

Migration from Antd 3.* to Antd 4.9 #2536

merged 23 commits into from
Dec 9, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 7, 2020

Motivation and context

Current Antd version is outdated. To get new features and solve some bugs (that have been solved in antd 4.*) we need to migrate to the latest version.

Resolve #1703

How has this been tested?

Manual testing, cypress tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev
Copy link
Member Author

There aren't any features that have been changed in this PR. All the changes are related with changing API of Antd library.
When testing, I would recommend pay attention to forms (especially create task, label constructor).
One more way to test is to compare page by page with cvat.org.

@nmanovic
Copy link
Contributor

nmanovic commented Dec 7, 2020

@bsekachev , if you find here any problems which are not covered by tests, it is a good idea to add such test cases.

@bsekachev bsekachev changed the title [WIP] Migration from Antd 3.* to Antd 4.9 Migration from Antd 3.* to Antd 4.9 Dec 8, 2020
azhavoro
azhavoro previously approved these changes Dec 9, 2020
@bsekachev bsekachev merged commit 8ae83c7 into develop Dec 9, 2020
@bsekachev bsekachev deleted the bs/antd4_migration branch December 11, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVAT UI: AntD migration from V3 to V4
3 participants