Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed saving of relative paths in dummy chunks instead of absolute #2424

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Nov 13, 2020

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 62.811% when pulling 397cc0a on mk/relative_paths_in_dummy_chunks into 5e2a9e3 on develop.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good and write. Tests work. Let's merge it.

@nmanovic nmanovic merged commit f2d0b71 into develop Nov 14, 2020
@nmanovic nmanovic deleted the mk/relative_paths_in_dummy_chunks branch November 14, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants