Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable fold single line #401

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Re enable fold single line #401

merged 2 commits into from
Jan 4, 2022

Conversation

AndreasArvidsson
Copy link
Member

Re enabled folding of single line. To "solve" the problem where fold every state will fold the parent if one of the states is a single line I added a constraint that you can't combine multi and single line targets. In that case just used the multiline targets. Multiple single line targets is fine though.

fixes #72

@pokey
Copy link
Member

pokey commented Dec 18, 2021

Tempted to introduce visible ranges to recorded tests for this one. As long as the file fits within a reasonable sized window I think it should be fairly straightforward

@AndreasArvidsson
Copy link
Member Author

Tempted to introduce visible ranges to recorded tests for this one. As long as the file fits within a reasonable sized window I think it should be fairly straightforward

I think that should probably be fine

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm going to approve this one without tests because adding support for visible range testing is probably out of scope for this PR. But it would be good to add that as a fast follow, because this folding stuff is getting a bit more complex than I'm comfortable not having tests for 😅

@AndreasArvidsson rather than requesting tests on this PR, I'll assign #160 to you to do after this one is merged in so that we don't clutter this PR. I think it actually should be fairly straightforward. But if you don't have capacity no worries feel free to assign it to me

@AndreasArvidsson AndreasArvidsson merged commit 14749f4 into main Jan 4, 2022
@AndreasArvidsson AndreasArvidsson deleted the fold_single_line_again branch January 4, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fold/unfold requires funk modifier
2 participants