Fix JSON surrounding pairs #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
fix-json-surrounding-pairs
branch
from
f9a250c
to
277303e
Compare
pokey
commented
Dec 8, 2021
| @@ -0,0 +1,99 @@ | |||
| import { SyntaxNode } from "web-tree-sitter"; | |||
There was a problem hiding this comment.
Moved stuff out of index.ts
| !ALLOWABLE_ANGLE_BRACKET_PARENTS.includes( | ||
| delimiterNode.parent?.type! | ||
| ) | ||
| inferDelimiterSide(delimiterNode) !== delimiterInfo.side |
There was a problem hiding this comment.
I think this approach will be more robust
| - type: primitive | ||
| modifier: {type: surroundingPair, delimiter: parentheses} | ||
| initialState: | ||
| documentContents: // (hello) |
There was a problem hiding this comment.
Note that we support comments in json now because we fallback to text-based if we're in a parse-tree error node
AndreasArvidsson
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364
Closes #355
<if it has sibling that is>?