Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change column modified to range vertical connector #353

Merged
merged 8 commits into from
Dec 8, 2021

Conversation

AndreasArvidsson
Copy link
Member

No description provided.

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor tweaks

src/core/inferFullTargets.ts Outdated Show resolved Hide resolved
src/typings/Types.ts Outdated Show resolved Hide resolved
@pokey pokey added this to the 0.24.0 milestone Dec 7, 2021
@AndreasArvidsson
Copy link
Member Author

@pokey The format of the test has changed and I can't figure it out. Can you solve the conflicts?

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

src/typings/Types.ts Outdated Show resolved Hide resolved
@AndreasArvidsson
Copy link
Member Author

@pokey More merge conflicts due to change in test format

@AndreasArvidsson AndreasArvidsson merged commit 66f160e into main Dec 8, 2021
@AndreasArvidsson AndreasArvidsson deleted the verticalRange branch December 8, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants