Delimiter selector updated #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndreasArvidsson
commented
Nov 30, 2021
•
AndreasArvidsson
commented
- Delimiter selector made more robust and usable for all languages
- Added a lot of language specific play/test files. They have very little in them right now but the purpose is that each language should have a file with all the common structures making it easier to test while developing.
pokey
reviewed
Dec 1, 2021
There was a problem hiding this comment.
I like this idea. A few things
- Looks like the line endings got messed up or something? Strange diffs
- Looks like a few junk files appeared, eg
tmp.tsxand a couple empty files. The markdown one also looks strange - Please add tests for the things you fixed
- I'd be tempted to put all the files, including hat-test, into a
data/playgrounddirectory. I think "test" is probably a confusing name because they're not actually tests. Prob my fault for calling it "hat-test". I think I'd maybe godata/playground/hats.txt,data/playground/typescript.ts, etc?
|
Now I think everything is fixed :) |
pokey
approved these changes
Dec 1, 2021
src/test/suite/fixtures/recorded/languages/java/chuckTypeNear.yml
Outdated
Show resolved
Hide resolved
| }, | ||
| ); | ||
| } else { | ||
| trailingDelimiterRange = makeRangeFromPositions( |
There was a problem hiding this comment.
What if we walked up parents until we find one with a previous sibling and then ask for end of previous sibling there? Not sure it's worth the effort but might make white space a bit cleaner
There was a problem hiding this comment.
We can't try that
There was a problem hiding this comment.
Did you mean to say "we can try that?"
There was a problem hiding this comment.
I don't think we have to. So far no language has need of this with the current implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.