Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put identifier before repeatable symbols #278

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Put identifier before repeatable symbols #278

merged 2 commits into from
Sep 20, 2021

Conversation

AndreasArvidsson
Copy link
Member

Since repeatable symbols was before identifier _a was split into two tokens

pokey
pokey reviewed Sep 19, 2021
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but could use a test

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Sep 19, 2021 •
edited
Loading

@pokey Test added

@pokey pokey merged commit e85e5f1 into main Sep 20, 2021
@pokey pokey deleted the regex_identifier branch September 20, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @pokey