Rename purple to pink #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Sep 6, 2021
| @@ -165,8 +165,8 @@ | |||
| "highContrast": "#f0b800" | |||
| } | |||
| }, | |||
| "cursorless.colors.purple": { | |||
| "description": "Color to use for purple symbols", | |||
| "cursorless.colors.pink": { | |||
There was a problem hiding this comment.
this will break settings for people who have a custom purple. was thinking of just pinging on slack before releasing?
AndreasArvidsson
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pink" will become the default term for this color in the next few weeks (see cursorless-dev/cursorless-talon#66), and we will change the default color to be more obviously pink. Hoping to reduce cognitive dissonance for colors
See also cursorless-dev/cursorless-talon#75