-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check ancestors for every #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good with a few comments. Also might add one test with nesting. Eg foo(bar(baz, bongo), bazman)
- anchor: {line: 1, character: 4} | ||
active: {line: 1, character: 17} | ||
- anchor: {line: 2, character: 4} | ||
active: {line: 2, character: 17} | ||
- anchor: {line: 1, character: 4} | ||
active: {line: 1, character: 17} | ||
- anchor: {line: 2, character: 4} | ||
active: {line: 2, character: 17} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really what we want? Appears selections are duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but has actually nothing to do with this pr. transformSelection/getNodeMatcher gets called for every selection. But might be a good idea to actually filter out duplicate selections at the end of the pipeline. You should probably put that on the task list for the new grammar.
fixes #220
Added a few tests