-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't do inference from end to start #143
Conversation
@brxck @sterlind I'm of the opinion that you should never do inference from back to front while pokey want it in the case of missing start mark. I want us to reach some consensus about this so I can do the changes. Because the original problem with |
So @AndreasArvidsson you're arguing that "take past line air" should select from cursor to the end of line containing 'a', rather than from beginning of current line to end of line containing 'a'? So in your version you'd say "take line past air" if you did in fact want to include the entire line containing cursor? I do feel that while we're using "past", this version is confusing, because it sounds like we want the line after "air". But if we switch to "through" when conformer number bugs are fixed, it's a bit clearer: "take line through air" or even "take lines through air" if we want to support plurals. Given that the code is simpler this way, I won't push too strongly against it if people feel it's intuitive |
I think Andreas's suggestion lines up with what I would intuitively expect. "through" would be a nice variation as I've caught myself trying to say it before. |
Ok cool let's get a couple tests in to make sure I can't sneak my old grammar in here and then merge it in! |
@pokey Tests added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Shall we add "take past line air" and "take line past air" before merging? Maybe I missed those?
@pokey Last two test added. Go ahead and merge. |
take air past line bat
should not take line for airtake air past state bat
should not take state for airWith this behavior now consistent we probably can just close #8