Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with two adjacent tokens #129

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Fixed bug with two adjacent tokens #129

merged 1 commit into from
Jul 21, 2021

Conversation

AndreasArvidsson
Copy link
Member

Issue #12

pokey
pokey approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't quite wrapped my head around what this one does for overlapping ranges, but looks like it will fix the bug and won't affect non-overlapping ranges so let's ship it

Closes #12

@pokey pokey merged commit f0612d9 into master Jul 21, 2021
@pokey pokey deleted the adjacent branch July 21, 2021 14:23
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@pokey @AndreasArvidsson
Some cheatsheet improvements (cursorless-dev#129)
f0b9346 
* Merge scope types in cheatsheet

* Add paired delimiters to cheat sheet

* Cleanup cheatsheet

* black

* Update max-y for the last column

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @pokey