Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "copy", "paste" and "cut" actions by moving selection and using built-ins #127

Closed
pokey opened this issue Jul 21, 2021 · 3 comments · Fixed by #141
Closed

Change "copy", "paste" and "cut" actions by moving selection and using built-ins #127

pokey opened this issue Jul 21, 2021 · 3 comments · Fixed by #141
Assignees

Comments

@pokey
Copy link
Member

pokey commented Jul 21, 2021

There are a lot of smarts baked into the built-in copy, paste, and cut actions. Rather than reimplementing them ourselves, it's probably easiest to first setSelection, then issue the built-in command, then setSelection back

@pokey
Copy link
Member Author

pokey commented Jul 23, 2021

Yep that's certainly part of it. There also must be code somewhere along the chain to be smart about tracking multi-cursor multi-line copies, and I think I remember seeing code trying to be smart about indentation, but not positive bout that one

@AndreasArvidsson
Copy link
Member

I as wanted to store that reference. I think I figure out how the smart logic works internally and agree we should use the the internal copy and past function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants