Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct rect setter #81

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Use correct rect setter #81

merged 1 commit into from
Sep 30, 2021

Conversation

SCdF
Copy link
Contributor

@SCdF SCdF commented Sep 30, 2021

No description provided.

@SCdF SCdF requested a review from pokey as a code owner September 30, 2021 11:21
@pokey
Copy link
Member

pokey commented Sep 30, 2021

@AndreasArvidsson I've verified that it doesn't break older beta version; would be awesome if you could have a look / double check latest beta

@pokey
Copy link
Member

pokey commented Sep 30, 2021

also I think this one is worth skipping develop on and merging straight into main

@pokey pokey merged commit 9f702a2 into cursorless-dev:main Sep 30, 2021
AndreasArvidsson pushed a commit that referenced this pull request Sep 30, 2021
@pokey @SCdF
Use correct rect setter (#81) (#82)
c203e9e 
Co-authored-by: Stefan du Fresne <stefan@sdufresne.info>
AndreasArvidsson pushed a commit that referenced this pull request Oct 8, 2021
@pokey @SCdF
Patch develop (#89)
164632b 
* Use correct rect setter (#81)

* Tweak shape docs (#88)

* Tried new SVGs

* Revert branch

Co-authored-by: Stefan du Fresne <stefan@sdufresne.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SCdF @pokey @AndreasArvidsson