Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take snapshots of hat map #101

Merged
merged 7 commits into from
Dec 6, 2021
Merged

Take snapshots of hat map #101

merged 7 commits into from
Dec 6, 2021

Conversation

pokey
Copy link
Member

@pokey pokey commented Nov 7, 2021

If the user has latest vscode client installed, we use hat snapshots to keep hats from changing during a phrase. If not we fall back to no snapshots, like we had before

@pokey pokey marked this pull request as ready for review December 3, 2021 17:42
@AndreasArvidsson
Copy link
Member

Looks good overall. Just realized it looks like we have a duplication of cursorless_single_target_command_with_arg_list(). Could you remove one of these?

@pokey
Copy link
Member Author

pokey commented Dec 4, 2021

Looks good overall. Just realized it looks like we have a duplication of cursorless_single_target_command_with_arg_list(). Could you remove one of these?

I have that fixed on #96 so I think I may just wait for that one to merge in to avoid a merge conflict

@pokey pokey mentioned this pull request Dec 6, 2021
13 tasks
@pokey pokey merged commit ad5c841 into develop Dec 6, 2021
@pokey pokey deleted the hat-snapshots branch December 6, 2021 17:11
pokey added a commit that referenced this pull request Dec 13, 2021
* Touch file impl

* Improved touch

* Fix field name

* Initial attempt at more robustness

* Working version

* Revert change to mark.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants