fix(utils): Modify getOwnPropertyDescriptor to hasOwnProperty prototy…

…pe function
cure53 · Jan 29, 2024 · aa4c194 · aa4c194
1 parent 9a1ba81
commit aa4c194
Show file tree

Hide file tree

Showing 9 changed files with 29 additions and 19 deletions.
diff --git a/dist/purify.cjs.js b/dist/purify.cjs.js
diff --git a/dist/purify.cjs.js.map b/dist/purify.cjs.js.map
diff --git a/dist/purify.es.mjs b/dist/purify.es.mjs
@@ -120,7 +120,8 @@ function addToSet(set, array) {
  */
 function cleanArray(array) {
   for (let index = 0; index < array.length; index++) {
-    if (getOwnPropertyDescriptor(array, index) === undefined) {
+    const isHasOwnProperty = Object.prototype.hasOwnProperty.call(array, index);
+    if (!isHasOwnProperty) {
       array[index] = null;
     }
   }
@@ -136,7 +137,8 @@ function cleanArray(array) {
 function clone(object) {
   const newObject = create(null);
   for (const [property, value] of entries(object)) {
-    if (getOwnPropertyDescriptor(object, property) !== undefined) {
+    const isHasOwnProperty = Object.prototype.hasOwnProperty.call(object, property);
+    if (isHasOwnProperty) {
       if (Array.isArray(value)) {
         newObject[property] = cleanArray(value);
       } else if (value && typeof value === 'object' && value.constructor === Object) {
@@ -169,8 +171,7 @@ function lookupGetter(object, prop) {
     }
     object = getPrototypeOf(object);
   }
-  function fallbackValue(element) {
-    console.warn('fallback value for', element);
+  function fallbackValue() {
     return null;
   }
   return fallbackValue;

diff --git a/dist/purify.es.mjs.map b/dist/purify.es.mjs.map
diff --git a/dist/purify.js b/dist/purify.js
diff --git a/dist/purify.js.map b/dist/purify.js.map
diff --git a/dist/purify.min.js b/dist/purify.min.js
diff --git a/dist/purify.min.js.map b/dist/purify.min.js.map
diff --git a/src/utils.js b/src/utils.js
@@ -115,7 +115,9 @@ function addToSet(set, array, transformCaseFunc = stringToLowerCase) {
  */
 function cleanArray(array) {
   for (let index = 0; index < array.length; index++) {
-    if (getOwnPropertyDescriptor(array, index) === undefined) {
+    const isHasOwnProperty = Object.prototype.hasOwnProperty.call(array, index);
+
+    if (!isHasOwnProperty) {
       array[index] = null;
     }
   }
@@ -133,7 +135,12 @@ function clone(object) {
   const newObject = create(null);
 
   for (const [property, value] of entries(object)) {
-    if (getOwnPropertyDescriptor(object, property) !== undefined) {
+    const isHasOwnProperty = Object.prototype.hasOwnProperty.call(
+      object,
+      property
+    );
+
+    if (isHasOwnProperty) {
       if (Array.isArray(value)) {
         newObject[property] = cleanArray(value);
       } else if (