Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to MediaObject #189

Open
sekaiking opened this issue Dec 18, 2021 · 2 comments
Open

Add type to MediaObject #189

sekaiking opened this issue Dec 18, 2021 · 2 comments
Labels
Frontend

Comments

@sekaiking
Copy link
Contributor

After this curaOS/contracts#3 gets implemented we should add type="image" to MediaObject components in the frontend, because now it assume all medias are HTML

And because of that, they get displayed wrong
image
@sekaiking sekaiking mentioned this issue Dec 23, 2021
Closed
@bestatigen
Copy link
Collaborator

It's working fine at the moment? @achrafismyname

@sekaiking
Copy link
Contributor Author

Yes and no, some NFTs got minted using this PR #194 and are causing this problem.
But it's not a big problem, this mainly need to be implemented after #194 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bestatigen @sekaiking