Recreate shares.json in case of deletion #952
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to clear shares when testing, we need to be able to reload
the json files after they have been deleted.
Later on, in a real-world scenario, we need to be able to rebuild the
json file based on information stored in the storage. (see inline TODO)
@butonic
Test steps:
Before this fix: the shares would still be there until the service is reloaded
After this fix: the shares are gone directly and the file is recreated empty.
TODOs: