Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): encode nats-js-kv keys #4862

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 23, 2024

Encode nats-js-kv keys. This got lost by a dependency bump.

complicated thing .... #4842 (comment) ... don't ask

in case someone has to dig in again:

nats-js-kv used to always encode the keys. we changed that upstream to make it configurable ... as a good citizen ... you know ... then we had to make ocis always encode the key ... which led to #4678 (comment)

so yea ... we always encode the key ...

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested review from labkode, glpatcern and a team as code owners September 23, 2024 11:51
@butonic butonic self-assigned this Sep 23, 2024
@butonic butonic mentioned this pull request Sep 23, 2024
@2403905 2403905 merged commit 30b3bf5 into cs3org:stable-2.19 Sep 23, 2024
10 checks passed
@butonic butonic deleted the backport/4678 branch September 23, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants