Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharejail stat #4835

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix sharejail stat #4835

merged 1 commit into from
Sep 30, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 4, 2024

Stating a share jail mountpoint now returns the same resourceid as in the directory listing of the share jail root.

This needs to be tested with WOPI, as I fear the web client might now try to use the sharejail id to access a resource ...

see owncloud/ocis#9933

Copy link

update-docs bot commented Sep 4, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic changed the base branch from master to edge September 4, 2024 13:46
@butonic butonic requested a review from a team as a code owner September 4, 2024 13:46
@butonic
Copy link
Contributor Author

butonic commented Sep 4, 2024

@micbar since you are knee deep in wopi work can you try this out with a working wopi setup?

@felix-schwarz
Copy link

@butonic Is there any way (test instance or similar) that we could use to verify if it fixes the issue for the iOS app and/or if there are any other side effects?

@micbar
Copy link
Member

micbar commented Sep 25, 2024

You could use the ocis_full docker compose locally on this branch. Checkout this branch, then

  1. make -C ocis dev-docker
  2. export OCIS_DOCKER_TAG=dev
  3. export OCIS_DOCKER_IMAGE=owncloud/ocis
  4. docker compose up -d
  5. use ocis.owncloud.test as url (needs etc/hosts entry)

@butonic butonic marked this pull request as draft September 25, 2024 11:54
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review September 26, 2024 15:33
@butonic butonic marked this pull request as draft September 26, 2024 15:33
@butonic
Copy link
Contributor Author

butonic commented Sep 26, 2024

while the implementation is correct, the ocis testsuite needs a fix: owncloud/ocis#10172 (comment)

@butonic butonic marked this pull request as ready for review September 30, 2024 12:15
@butonic
Copy link
Contributor Author

butonic commented Sep 30, 2024

test got added to expected failures, merging

@butonic butonic merged commit c33c803 into cs3org:edge Sep 30, 2024
9 of 10 checks passed
@butonic butonic deleted the fix-sharejail-stat-id branch September 30, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants